Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SpaceX Website Clone #426

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

AmrutaJayanti
Copy link
Contributor

Closes: #407

  • Title : SpaceX Clone
  • Name: : Amruta Jayanti
  • Idenitfy yourself: : GSSOC

Describe the add-ons or changes you've made 📃

I added SpaceX-Website-Clone

How Has This Been Tested? ⚙️

I tested it locally .

Screenshots 📷

Screenshot 2024-06-29 080057

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Note to reviewers 📄

Copy link

vercel bot commented Jun 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2024 7:22am

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmrutaJayanti keep the screenshot.webp file outside the img folder. Just alongside README.md file.

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 29, 2024
@AmrutaJayanti
Copy link
Contributor Author

@Avdhesh-Varshney I made the changes . Please approve . Its showing conflicts must be resolved

@AmrutaJayanti
Copy link
Contributor Author

@Avdhesh-Varshney I resolved the conflicts also . Please approve .

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmrutaJayanti PR Approved 🎉

@Avdhesh-Varshney Avdhesh-Varshney merged commit e587055 into Avdhesh-Varshney:main Jul 1, 2024
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added level1 Beginner level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors Front-end 👻 These project are kept in Front-end directory gssoc These issue/pull request will be considered for GSSOC'24 and removed bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors Front-end 👻 These project are kept in Front-end directory gssoc These issue/pull request will be considered for GSSOC'24 level1 Beginner level issues/pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📃: SpaceX Clone
2 participants