Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Clone added #341

Closed
wants to merge 2 commits into from
Closed

Conversation

zalabhavy
Copy link
Contributor

@zalabhavy zalabhavy commented Jun 17, 2024

Closes:

  • Title : Microsoft Clone
  • Name: : Bhavy Zala
  • Idenitfy yourself: : Gssoc'24

Describe the add-ons or changes you've made 📃

Added new folder Microsoft-Clone with README.md.
Update json file in database.
Update README.md in frontend folder.

How Has This Been Tested? ⚙️

Self testing..

Screenshots 📷

image
image
image

Type of change ☑️

What sort of change have you made:

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Code style update (formatting, local variables)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Note to reviewers 📄

Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 9:45am

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@zalabhavy
Copy link
Contributor Author

@Avdhesh-Varshney Please check it and merge !

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zalabhavy follow the project folder structure properly.
Keep a ss file just inside the project folder with named screenshot in webp format and leave other used images inside the images directory.

Also link your issue with pr properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants