Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Virtual-Piano #320

Merged
merged 2 commits into from
Jun 15, 2024
Merged

added Virtual-Piano #320

merged 2 commits into from
Jun 15, 2024

Conversation

VaishnaviMankala19
Copy link
Contributor

@VaishnaviMankala19 VaishnaviMankala19 commented Jun 14, 2024 •
edited by Avdhesh-Varshney
Loading

Closes: #271

  • Title : Virtual-Piano
  • Name: : MANKALA VAISHNAVI
  • Idenitfy yourself: : GSSOC24

Describe the add-ons or changes you've made 📃

I have added Virtual-Piano

How Has This Been Tested? ⚙️

Screenshots 📷

Screenshot (24)

Type of change ☑️

What sort of change have you made:

  • New feature (non-breaking change which adds functionality)

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Note to reviewers 📄

@vercel Vercel
Copy link

vercel bot commented Jun 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 10:06am

@github-actions GitHub Actions
Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Avdhesh-Varshney Avdhesh-Varshney added the Requested Changes ⚙️ Some changes have been requested in this PR label Jun 14, 2024
@VaishnaviMankala19
Copy link
Contributor Author

updated the changes that are mentioned

Avdhesh-Varshney
Avdhesh-Varshney approved these changes Jun 15, 2024
View reviewed changes
Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VaishnaviMankala19 PR Approved 🎉
Carefully link your issue with pr

@Avdhesh-Varshney Avdhesh-Varshney merged commit 1430ad0 into Avdhesh-Varshney:main Jun 15, 2024
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added level1 Beginner level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors Vanilla-JS 😊 These project are kept in Vanilla-JS directory gssoc These issue/pull request will be considered for GSSOC'24 and removed Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 15, 2024
@VaishnaviMankala19 VaishnaviMankala19 deleted the Virtual-Piano branch June 16, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avdhesh-Varshney Avdhesh-Varshney Avdhesh-Varshney approved these changes

Assignees

@VaishnaviMankala19 VaishnaviMankala19

Labels
Approved ✔️ This PR is approved by the PR or, Mentors gssoc These issue/pull request will be considered for GSSOC'24 level1 Beginner level issues/pull requests Vanilla-JS 😊 These project are kept in Vanilla-JS directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📃: VIRTUAL PIANO
2 participants
@VaishnaviMankala19 @Avdhesh-Varshney