Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Markdown Previewer #231

Merged
merged 7 commits into from
Jun 3, 2024

Conversation

AmrutaJayanti
Copy link
Contributor

Pull Request for WebMasterLog 💡

Issue Title: Project: Markdown Previewer

  • Name of the project : Markdown Previewer
  • Category: Vanilla
  • Name: Amruta Jayanti
  • GitHub ID: AmrutaJayanti
  • Idenitfy yourself: GSSOC Contributor

Closes: #218

Describe the add-ons or changes you've made 📃

I added a Markdown Previewer directory in Vanilla-Js/Advanced

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

Screenshot 2024-05-30 193250

Note to reviewers 📄

Please approve

Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 2:00pm

Copy link

github-actions bot commented Jun 2, 2024

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmrutaJayanti don't forget to update your readme.

  • But this markdown previewer is able to preview the code part?
  • Work on it to make it a complete application.

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 3, 2024
@AmrutaJayanti
Copy link
Contributor Author

@Avdhesh-Varshney I made the changes . Please approve

@AmrutaJayanti
Copy link
Contributor Author

@Avdhesh-Varshney Sorry for the inconvenience. Please approve

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmrutaJayanti PR Approved 🎉

@Avdhesh-Varshney Avdhesh-Varshney merged commit f4766fe into Avdhesh-Varshney:main Jun 3, 2024
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added level2 Intermediate level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors Vanilla-JS 😊 These project are kept in Vanilla-JS directory and removed bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 3, 2024
@Avdhesh-Varshney Avdhesh-Varshney added the gssoc These issue/pull request will be considered for GSSOC'24 label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors gssoc These issue/pull request will be considered for GSSOC'24 level2 Intermediate level issues/pull requests Vanilla-JS 😊 These project are kept in Vanilla-JS directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project 📃: Markdown Previewer
2 participants