Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added World clock #220

Merged
merged 6 commits into from
Jun 2, 2024
Merged

Conversation

Asymtode712
Copy link
Contributor

Pull Request for WebMasterLog 💡

Issue Title: #203

  • Name of the project : World Clock
  • Category: Vanilla
  • Name: Siddheya Kulkarni
  • GitHub ID: https://github.com/Asymtode712
  • Idenitfy yourself: GSSOC contributor

Closes: #203

Describe the add-ons or changes you've made 📃

Added World Clock Project which enables an user to determine the current time of various specified regions of the world. It is implemented using HTML, CSS and Javascript and uses WorldTimeAPI for fetching real time data.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

WC

Note to reviewers 📄

@Avdhesh-Varshney please review and merge this PR if it is good to go

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 9:30am

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Asymtode712 directory name should be World-Clock ok.
Also enlist this project in the README file of Vanilla JS projects.

@Avdhesh-Varshney Avdhesh-Varshney added the Requested Changes ⚙️ Some changes have been requested in this PR label May 31, 2024
@Asymtode712
Copy link
Contributor Author

@Avdhesh-Varshney done with the changes please review them once

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Asymtode712 PR Approved 🎉
But still you have not enlist your project in the main readme file.
For this time, i will update it.

@Avdhesh-Varshney Avdhesh-Varshney merged commit f812906 into Avdhesh-Varshney:main Jun 2, 2024
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added level1 Beginner level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors Vanilla-JS 😊 These project are kept in Vanilla-JS directory gssoc These issue/pull request will be considered for GSSOC'24 and removed Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors gssoc These issue/pull request will be considered for GSSOC'24 level1 Beginner level issues/pull requests Vanilla-JS 😊 These project are kept in Vanilla-JS directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project 📃: World Clock
2 participants