Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptocurrency Finder added #208

Merged
merged 3 commits into from
May 31, 2024

Conversation

Saimanjari777
Copy link
Contributor

@Saimanjari777 Saimanjari777 commented May 29, 2024

Pull Request for WebMasterLog 💡

Issue Title: Cryptocurrency Finder using React JS

Closes: #198

Describe the add-ons or changes you've made 📃

I have added react JS crypto currency Finder which displays different crypto coins using API.

Type of change ☑️

What sort of change made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

I have tested this on my local system

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

Screenshot 2024-05-27 221016

Note to reviewers 📄

Hey, @Avdhesh-Varshney Please check once and do let me know if any changes required.

I have added cryptocurrency finder under react JS projects
Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 6:06pm

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saimanjari777 as mentioned your issue a level2. So, put this project inside the Intermediate directory not in Basic directory.

Refill the pr template carefully.

image

package-lock.json Outdated Show resolved Hide resolved
React-JS-Projects/README.md Outdated Show resolved Hide resolved
database/react.json Outdated Show resolved Hide resolved
@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels May 30, 2024
@Saimanjari777
Copy link
Contributor Author

I have made the changes, Please check once @Avdhesh-Varshney

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saimanjari777 PR Approved 🎉
Join the discord server.

@Avdhesh-Varshney Avdhesh-Varshney merged commit 6b89e8d into Avdhesh-Varshney:main May 31, 2024
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added level2 Intermediate level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors React-JS 😍 These project are kept in React-JS directory gssoc These issue/pull request will be considered for GSSOC'24 and removed bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors gssoc These issue/pull request will be considered for GSSOC'24 level2 Intermediate level issues/pull requests React-JS 😍 These project are kept in React-JS directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project 📃: Cryptocurrency Finder App in React
2 participants