Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI of card #187

Merged
merged 6 commits into from
May 26, 2024
Merged

UI of card #187

merged 6 commits into from
May 26, 2024

Conversation

Priya-49
Copy link
Contributor

@Priya-49 Priya-49 commented May 25, 2024

Pull Request for WebMasterLog 💡

Issue Title: Card UI enhancement and fixed top-navbar.

  • Name of the project : WebMasterLog
  • Category: Front-end
  • Name: P.Priyanka
  • GitHub ID: https://github.com/Priya-49
  • Idenitfy yourself: GSSOC

Closes: #159

Describe the add-ons or changes you've made 📃

I added a hover effect to the cards, title to the icons in the card and a min height and width so that the card doesn't shrink when there is no image.

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

Screenshot (214)

Copy link

vercel bot commented May 25, 2024

@Priya-49 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link

vercel bot commented May 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 0:34am

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Priya-49 try to re-scale the card so that on hover, other cards will not disturb.

@Avdhesh-Varshney Avdhesh-Varshney added the Requested Changes ⚙️ Some changes have been requested in this PR label May 25, 2024
@Priya-49
Copy link
Contributor Author

@ Avdhesh-Varshney
I have made the requested changes

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Priya-49 PR Approved. 🎉

@Avdhesh-Varshney Avdhesh-Varshney merged commit 3e7cc7a into Avdhesh-Varshney:main May 26, 2024
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added enhancement 🧑‍💻 New feature or request level2 Intermediate level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors gssoc These issue/pull request will be considered for GSSOC'24 and removed Requested Changes ⚙️ Some changes have been requested in this PR labels May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors enhancement 🧑‍💻 New feature or request gssoc These issue/pull request will be considered for GSSOC'24 level2 Intermediate level issues/pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement 🧑‍💻: Cards UI enhacement and fixed top navbar
2 participants