Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Quote Generator Website #176

Closed

Conversation

Santhosh-Siddhardha
Copy link

Pull Request for WebMasterLog 💡

Issue Title: Project 📃: Random Quote Generator

  • Name of the project : Random Quote Generator
  • Category: Vanilla-JS-Projects
  • Name: Lingamuneni Santhosh Siddhardha
  • GitHub ID: Santhosh-Siddhardha
  • Idenitfy yourself: GSSOC Contributor

Closes: #170

Describe the add-ons or changes you've made 📃

This web application generates a random quote from a predefined dataset when a button is clicked. Perfect for a quick dose of inspiration or a thoughtful moment!, Which is built using HTML,CSS,JavaScript.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

The website has been tested for various edge cases to ensure proper generation.

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

image

image

Note to reviewers 📄

NA

Added Description
Added Details
Added Screenshots
Added Author section
Added index.html
Added style.css
Added style.js 
Added data for quotes
Added Random Quote generator
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 8:47am

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Santhosh-Siddhardha Nice PR.
But no ss present and no new branch has created by you. So, create a new pr by rectify with the mentioned changes.

  • And try to fetch the images if urls of images are present the dataset. OK.

For further communication or queries, join the discord server https://discord.gg/tSqtvHUJzE.

<button class = "btn">Generate</button>
</div>
</div>
<div class="footer">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this footer section from the project. No need of it for the project WebMasterLog.

@Avdhesh-Varshney Avdhesh-Varshney added the bug 🐛 Something isn't working label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants