Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictonary App using Javascript Solved #163 #168

Closed
wants to merge 1 commit into from

Conversation

Damini2004
Copy link
Contributor

Pull Request for WebMasterLog 💡

Issue Title: Dictonary App using Javascript #163

  • Name of the project : Dictonary App using Javascript
  • Category: Vanilla Js
  • Name: Damini Chachane
  • GitHub ID: https://github.com/Damini2004
  • Idenitfy yourself: GSSOC

Closes: #163

Describe the add-ons or changes you've made 📃

Here i have fetch the api of Free Dictonary viw which we can find the meaning ,part of speech,pronounciation,etc.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

Screenshot 2024-05-20 013708

Note to reviewers 📄

Copy link

vercel bot commented May 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 8:40pm

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Damini2004 Put this project inside the Basic directory not in Intermediate directory.

@@ -0,0 +1,64 @@
<h1 align='center'><b>💥 Email Subscription form with Google Sheet 💥</b></h1>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the title of README.

@@ -51,6 +51,8 @@
| 24 | [Language Translator](./Intermediate/Language-Translator/) | ![Intermediate](https://img.shields.io/badge/Intermediate-FFD700?style=for-the-badge) |
| 25 | [Ceaser-Cipher](./Intermediate/Ceaser-Cipher/) | ![Intermediate](https://img.shields.io/badge/Intermediate-FFD700?style=for-the-badge) |
| 26 | [Email-Subscription-form-with-google-sheet](./Intermediate/Email-Subscription-form-with-google-sheet/) | ![Intermediate](https://img.shields.io/badge/Intermediate-FFD700?style=for-the-badge) |
| 27 | [Dictonary-App](./Intermediate/Dictonary-App/) | ![Intermediate](https://img.shields.io/badge/Intermediate-FFD700?style=for-the-badge) |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in issue with level1, so it is a basic level project.
Remove Intermediate tag and add basic level tag.

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels May 22, 2024
@Avdhesh-Varshney Avdhesh-Varshney added wontfix ❌ This will not be worked on and removed Requested Changes ⚙️ Some changes have been requested in this PR labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project 📃: Dictonary App using Javascript
2 participants