Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Subscription form with google sheet #162

Merged
merged 3 commits into from
May 19, 2024

Conversation

Damini2004
Copy link
Contributor

@Damini2004 Damini2004 commented May 18, 2024

/## Pull Request for WebMasterLog 💡

Issue Title: #128

Closes: #128

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

Screenshot 2024-05-18 232117
Uploading Screenshot 2024-05-19 010216.png…

Note to reviewers 📄

Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 7:29pm

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Damini2004 PR Approved 🎉
Suggestions to you,

  • For any new pr, you have to switch in main branch and update your repository.
  • Then create a new branch for new project/issue/pr.
  • This is a good way to contribute in open-source community.

And I have labelled the gssoc and level tags on the PR. No need to copy and paste the same line of beneficial.
For any further communication and queries, join the discord server https://discord.gg/tSqtvHUJzE

@Avdhesh-Varshney Avdhesh-Varshney changed the title Email Subscription form with google sheet #128 Email Subscription form with google sheet May 19, 2024
@Avdhesh-Varshney Avdhesh-Varshney merged commit ccc355a into Avdhesh-Varshney:main May 19, 2024
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added level2 Intermediate level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors Vanilla-JS 😊 These project are kept in Vanilla-JS directory gssoc These issue/pull request will be considered for GSSOC'24 labels May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors gssoc These issue/pull request will be considered for GSSOC'24 level2 Intermediate level issues/pull requests Vanilla-JS 😊 These project are kept in Vanilla-JS directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project 📃: Email Subscription form with google sheet
2 participants