Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Ceaser Cipher Conversion Project #147

Merged
merged 9 commits into from
May 17, 2024

Conversation

Damini2004
Copy link
Contributor

@Damini2004 Damini2004 commented May 15, 2024

Pull Request for WebMasterLog 💡

Issue Title: Ceaser Cipher Conversion Project

  • Name of the project : Ceaser Cipher Conversion Project
  • Category: Vanilla-JS-Projects
  • Name: Damini Chachane
  • GitHub ID: https://github.com/Damini2004
  • Idenitfy yourself: GSSOC Contributor

Closes: #124

Describe the add-ons or changes you've made 📃

Made a Cipher text language conversion which helps you in changing a ciphertext into your plain language

Type of change ☑️

What sort of change have you made:

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested? ⚙️

It has been tested on several text as per its key from ciphertext to plaintext and vice versa.

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

dark
light

Note to reviewers 📄

Kindly go throught it

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 8:23am

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this file with screenshot name.
And don't forget to update README file from light.webp to screenshot.webp file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the respective changes sir kindly merge my project.

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels May 16, 2024
Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Damini2004 PR Approved 🎉
But still you have not linked you issue with the PR. But i have linked it so take a review on it.

@Avdhesh-Varshney Avdhesh-Varshney added level2 Intermediate level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors Vanilla-JS 😊 These project are kept in Vanilla-JS directory gssoc These issue/pull request will be considered for GSSOC'24 and removed bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels May 17, 2024
@Avdhesh-Varshney Avdhesh-Varshney changed the title Project Ceaser Cipher Conversion Project #127 Project Ceaser Cipher Conversion Project May 17, 2024
@Avdhesh-Varshney Avdhesh-Varshney merged commit cb5850c into Avdhesh-Varshney:main May 17, 2024
4 checks passed
@Damini2004
Copy link
Contributor Author

Kindly add GSSOC 24 label that will be more beneficial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors gssoc These issue/pull request will be considered for GSSOC'24 level2 Intermediate level issues/pull requests Vanilla-JS 😊 These project are kept in Vanilla-JS directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caesar Cipher Conversion project using javascript
2 participants