Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix #21 circulation dependence #22

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: fix #21 circulation dependence #22

wants to merge 5 commits into from

Conversation

maonaoda
Copy link
Contributor

@maonaoda maonaoda commented May 22, 2024 •
edited
Loading

#21

dansiegel
dansiegel requested changes May 22, 2024
View reviewed changes
src/MauiMicroMvvm/Internals/DefaultNavigation.cs

public DefaultNavigation(TShell shell)
public DefaultNavigation(IServiceProvider services)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should avoid injecting the IServiceProvider unless it is absolutely necessary. In this case it make more sense to simply add a registration for Lazy<TShell> and inject it directly.

@gerfen gerfen mentioned this pull request Nov 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansiegel dansiegel dansiegel requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maonaoda @dansiegel