Fix errors on updating the draft and pending status #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft and pending statuses can now be renamed with this PR! |
| // translators: %s: Post status, like "Draft" | ||
| return new WP_Error( 'restricted', sprintf( __( 'Changing the name and slug of a restricted status (%s) is not allowed.', 'vip-workflow' ), $old_status->name ) ); | ||
| // If the name was changed, we need to change the slug unless its banned from slug updates | ||
| if ( isset( $args['name'] ) && $args['name'] !== $old_status->name && ! self::is_status_banned_from_slug_changes( $old_status->slug ) ) { |
There was a problem hiding this comment.
I think we can remove the ! self::is_status_banned_from_slug_changes( $old_status->slug ) check from here, as the code unsets $args['slug'] if the status is banned below anyway.
There was a problem hiding this comment.
Tbh, I put it there for safety reasons just in case
Co-authored-by: Alec Geatches <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deletion of restricted statuses is still not allowed but this would be a good middle ground imo.
Steps to Test