perf: make a few micro-optimizations to help speed up findOne() #15022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
approved these changes
Nov 7, 2024
lib/query.js
Outdated
| @@ -2291,9 +2293,9 @@ Query.prototype.mongooseOptions = function(v) { | |||
|
|
|||
| Query.prototype._castConditions = function() { | |||
| let sanitizeFilterOpt = undefined; | |||
| if (this.model != null && utils.hasUserDefinedProperty(this.model.db.options, 'sanitizeFilter')) { | |||
| if (this.model != null && this.model.db.options?.sanitizeFilter != null) { | |||
There was a problem hiding this comment.
Can also be shortened to:
Suggested change
| if (this.model != null && this.model.db.options?.sanitizeFilter != null) { | |
| if (this.model?.db.options?.sanitizeFilter != null) { |
lib/query.js
Outdated
| sanitizeFilterOpt = this.model.db.options.sanitizeFilter; | ||
| } else if (this.model != null && utils.hasUserDefinedProperty(this.model.base.options, 'sanitizeFilter')) { | ||
| } else if (this.model != null && this.model.base.options?.sanitizeFilter != null) { |
There was a problem hiding this comment.
Same here
Suggested change
| } else if (this.model != null && this.model.base.options?.sanitizeFilter != null) { | |
| } else if (this.model?.base.options?.sanitizeFilter != null) { |
AbdelrahmanHafez
approved these changes
Nov 7, 2024
BenaliDjamel
reviewed
Dec 7, 2024
| @@ -2248,6 +2247,9 @@ Query.prototype.error = function error(err) { | |||
| */ | |||
|
|
|||
| Query.prototype._unsetCastError = function _unsetCastError() { | |||
| if (this._error == null) { | |||
| return; | |||
| } | |||
| if (this._error != null && !(this._error instanceof CastError)) { | |||
There was a problem hiding this comment.
@vkarpov15 Since you already checked (this._error == null) above, you can simplify the condition as below.
if (!(this._error instanceof CastError)) {}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #14906
Summary
Some small improvements that maybe give us an extra 1-2% on performance. Not huge, but a step in the right direction. I'm still debugging to see where we can find some extra perf.
Examples