Social | Fix publicize crashing when activated from the editor

[manzoorwanijk]

When Jetpack is active and the publicize module is off, if you try to activate publicize from the editor, it crashes.

The reason for the issue is lack of some script data (initial state) that sets things up when social is activated.

Proposed changes:

• Pass the bare minimum scipt-data to the editor when Social is turned OFF

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Turn OFF publicize from Jetpack settings > Sharing
• Goto Editor
• Open Jetpack sidebar
• Expand "Share this post" panel
• Click on "Activate Jetpack Social"
• Confirm that the module is activated and there is no error
• Goto Social settings page
• Confirm that the information and settings on the page are correct

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/publicize-activation-crash-in-the-editor branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/publicize-activation-crash-in-the-editor
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Social plugin:

• Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jeherve]

Confirm that the module is activated and there is no error

The module was activated, but if I then click on "Connect an account", I do not get any available networks in the modal:

[manzoorwanijk]

The module was activated, but if I then click on "Connect an account", I do not get any available networks in the modal:

Yeah, that's what we have for now and that has always been like that. It's because we cannot fetch the supported networks from WPCOM unless publicize is activated.

I will create a follow up task to create a REST endpoint to fetch the networks list when the module is activated.

[manzoorwanijk]

I have added it to our board https://github.com/Automattic/jetpack-reach/issues/704

[pablinos]

I will create a follow up task to create a REST endpoint to fetch the networks list when the module is activated.

I think if we're doing that then we should do what we were discussing and get the initial state after the module is activated.

@jeherve - @manzoorwanijk and I were discussing that this feature creates a few headaches where the module needs to be in a strange half-activated state to render the nudge and button. What do you think about swapping it to a link out to the settings screen to enable the feature? We could merge this for now of course, to stop the error, but creating extra endpoints etc seems like too much effort right now.

[jeherve]

What do you think about swapping it to a link out to the settings screen to enable the feature?

It's not perfect, but that may indeed be the best UX we can hope for. 👍

[manzoorwanijk]

Closing in favour of #40390