-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scan JS Package: Remove Build #40318
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Co-authored-by: Brad Jorsch <[email protected]>
dd078d8
to
8150425
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ensure compatibility with
__()
and@wordpress/i18n
, the scan package needs to be built by consumers such as the Jetpack and Jetpack Protect plugins.
As mentioned at peb6dq-3as-p2#comment-2024, this isn't really a good reason to do this. But there are other reasons you might decide to make the package TS-only (at least for now), and this PR is good to do that.
Closing in favor of #40299 |
To ensure compatibility with
__()
and@wordpress/i18n
, thescan
package needs to be built by consumers such as the Jetpack and Jetpack Protect plugins.Proposed changes:
package.json
file, opting to provide the TS source code directly to consumers.jetpack:src
fromexports
, sincedefault
is now the same./src/index.ts
value.Other information:
Jetpack product discussion
p1732032090059999-slack-CDLH4C1UZ
peb6dq-36i-p2
#40262
#40299
Does this pull request change what data or activity we track or use?
No
Testing instructions:
cd projects/js-packages/storybook && npm run storybook:dev
http://localhost:50240/?path=/docs/js-packages-components-threat-fixer-button--docs