-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Graph: Always output tags if they haven't been. #40213
base: trunk
Are you sure you want to change the base?
Conversation
Currently we only output the Open Graph tags if the sharing or Publicize modules are enabled and there are no known conflicting plugins active. This removes the module check, but adds a check where we capture the output of wp_head, and then see if any of the tags have been output already. If not then we render them.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Currently we only output the Open Graph tags if the sharing or Publicize modules are enabled and there are no known conflicting plugins active.
Proposed changes:
This removes the module check, but adds a check where we capture the output of wp_head, and then see if any of the tags have been output already. If not then we render them.
This change means that the default behaviour is flipped, so that Open Graph tags are always rendered, unless they're disabled.
I'm also slightly concerned about using output buffering, as I don't know if that will affect performance adversely, or if it could cause other problems.
Fixes #39225
Other information:
Does this pull request change what data or activity we track or use?
No.
Testing instructions: