Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Remove user connection nudge from stats at a glance #39496

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Dashboard: Remove user connection nudge from stats at a glance #39496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e1adc2
Remove user connection nudge from Stats module on At A Glance
CodeyGuyDylan Sep 23, 2024
3a4515f
changelog
CodeyGuyDylan Sep 23, 2024
ce023f4
Remove unused variable
CodeyGuyDylan Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions projects/plugins/jetpack/_inc/client/at-a-glance/stats/dash-stats-bottom.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,11 @@ import { createInterpolateElement } from '@wordpress/element';
import { __, _x, _n, sprintf } from '@wordpress/i18n';
import clsx from 'clsx';
import Button from 'components/button';
import ConnectButton from 'components/connect-button';
import analytics from 'lib/analytics';
import PropTypes from 'prop-types';
import React, { Component } from 'react';
import { Component } from 'react';
import { connect } from 'react-redux';
import { isOdysseyStatsEnabled, isWoASite, userCanConnectAccount } from 'state/initial-state';
import { isOdysseyStatsEnabled } from 'state/initial-state';

class DashStatsBottom extends Component {
statsBottom() {
Expand Down Expand Up @@ -108,16 +107,6 @@ class DashStatsBottom extends Component {
),
} )
}
{ ! this.props.isLinked && this.props.userCanConnectAccount && (
<ConnectButton
connectUser={ true }
from="unlinked-user-connect"
connectLegend={ __(
'Connect your WordPress.com account for more metrics',
'jetpack'
) }
/>
) }
{ this.props.isLinked &&
! this.props.isOdysseyStatsEnabled && // Only show if Odyssey Stats is disabled
createInterpolateElement(
Expand Down Expand Up @@ -165,7 +154,5 @@ DashStatsBottom.defaultProps = {
export default connect( state => {
return {
isOdysseyStatsEnabled: isOdysseyStatsEnabled( state ),
isWoASite: isWoASite( state ),
userCanConnectAccount: userCanConnectAccount( state ),
};
} )( DashStatsBottom );
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/remove-user-connection-nudge-from-stats-at-a-glance
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: other

Remove user connection nudge from Stats module on the dashboard
Loading