-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack AI: remove default style parameter from jetpack-ai-image requests #39494
Jetpack AI: remove default style parameter from jetpack-ai-image requests #39494
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed changes:
Stop sending a default
style
parameter on image (featured and general) generation requests. The default is handled on backend and we'll need the parameter to be optional yet deliberate once we implement the styles.Other information:
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Sandbox public-api.
Without checking out the branch, I recommend you trigger an image generation from our usual 3 spots:
Then checkout the branch, build/watch both js-packages/ai-client and plugins/jetpack, then reload and repeat the 3 generation requests (same prompts).
Observe:
style
parameter didn't change anything)jetpack-ai-image
) payloads to see thestyle
parameter is not present on the requests