Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin bar: ensure the Atomic debug bar is the leftmost menu #39493

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

fushar
Copy link
Contributor

@fushar fushar commented Sep 23, 2024

Fixes:

Proposed changes:

This PR ensures that the debug bar on Automattician's Atomic sites (under proxy) is the leftmost menu, similar to where it was before the "Nav Redesign".

One rationale is to avoid "masterbar jumps" when switching between Atomic and Simple sites.

Before

image

After

image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Prepare an Atomic site with Jetpack Beta Tester.
  2. Patch this PR.
  3. Go to /wp-admin while proxied; verify that the Debug bar is on the left.
  4. Go to /wp-admin while not proxied; verify that the Debug bar not there and everything still works.
  5. Test on site frontend as well.

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the debug-bar-left branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin debug-bar-left
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@fushar fushar marked this pull request as ready for review September 23, 2024 15:30
@fushar fushar requested a review from a team September 23, 2024 15:30
@fushar fushar self-assigned this Sep 23, 2024
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Go to /wp-admin while proxied; verify that the Debug bar is on the left.
Screenshot 2024-09-24 at 11 45 57 AM

✅ Go to /wp-admin while not proxied; verify that the Debug bar not there and everything still works.
Screenshot 2024-09-24 at 11 47 07 AM

✅ Test on site frontend as well.
Screenshot 2024-09-24 at 11 46 14 AM

@fushar fushar merged commit 6e432d4 into trunk Sep 24, 2024
56 checks passed
@fushar fushar deleted the debug-bar-left branch September 24, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants