-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forms: fix Single and Multiple Choice fields view styles #39473
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
@@ -399,6 +399,7 @@ | |||
border-radius: var(--jetpack--contact-form--button-outline--border-radius); | |||
padding: var(--jetpack--contact-form--button-outline--padding); | |||
line-height: var(--jetpack--contact-form--button-outline--line-height); | |||
align-items: center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align items in the center in Button mode so the padding looks similar at the top and bottom.
&.field-option-radio .jetpack-option__type { | ||
.jetpack-field-option.field-option-radio, | ||
.wp-block-jetpack-field-option-radio { | ||
.jetpack-option__type { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selector needs to be updated because of #39141
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well for me! As an aside, I tested with Twenty Twenty (on Jurassic Ninja) while trying different themes and noticed that the text color in the buttons is the same color as the button itself so it doesn't show. However this was the same on trunk too, so not related to this PR.
Proposed changes:
This PR updates the styles of the Single Choice and Multiple Choice fields so they match in the editor and view.
Ideally, we'd prevent code duplication but that's out of scope here.
Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
No.
Testing instructions: