Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms: fix Single and Multiple Choice fields view styles #39473

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

monsieur-z
Copy link
Contributor

Proposed changes:

This PR updates the styles of the Single Choice and Multiple Choice fields so they match in the editor and view.

Editor View
Screenshot 2024-09-19 at 4 19 35 PM Screenshot 2024-09-19 at 4 21 41 PM
Screenshot 2024-09-19 at 4 28 53 PM Screenshot 2024-09-19 at 4 28 58 PM

Ideally, we'd prevent code duplication but that's out of scope here.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Spin up a test Jetpack site
  • Create a new post
  • Add the Single Choice and Multiple Choice fields in a form
  • Open the preview
  • Notice the fields look like they do in the editor
  • Back in the editor, select the Button style from the block sidebar
Screenshot 2024-09-19 at 4 52 44 PM
  • Open the preview
  • Notice the fields look like they do in the editor

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/choice-fields-styles branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/choice-fields-styles
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@@ -399,6 +399,7 @@
border-radius: var(--jetpack--contact-form--button-outline--border-radius);
padding: var(--jetpack--contact-form--button-outline--padding);
line-height: var(--jetpack--contact-form--button-outline--line-height);
align-items: center;
Copy link
Contributor Author

@monsieur-z monsieur-z Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align items in the center in Button mode so the padding looks similar at the top and bottom.

&.field-option-radio .jetpack-option__type {
.jetpack-field-option.field-option-radio,
.wp-block-jetpack-field-option-radio {
.jetpack-option__type {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector needs to be updated because of #39141

Copy link
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me! As an aside, I tested with Twenty Twenty (on Jurassic Ninja) while trying different themes and noticed that the text color in the buttons is the same color as the button itself so it doesn't show. However this was the same on trunk too, so not related to this PR.

@monsieur-z monsieur-z merged commit f103fa7 into trunk Sep 24, 2024
58 of 59 checks passed
@monsieur-z monsieur-z deleted the fix/choice-fields-styles branch September 24, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants