Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pnpm 9.3.0 #37780

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Update to pnpm 9.3.0 #37780

merged 1 commit into from
Jun 10, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jun 10, 2024

Proposed changes:

Last week we updated from pnpm 8 to pnpm 9.2.0, and then today they released 9.3.0 with a change in the lock file.

We're already running into problems with Renovate PRs, as Renovate is generating lock files using 9.3.0 which our CI is unhappy with.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1718030102262129/1718026379.185019-slack-C05Q5HSS013
P2 post: pdWQjU-MK-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • CI happy?

Last week we updated from pnpm 8 to pnpm 9.2.0, and then today they
released 9.3.0 with a change in the lock file.
@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal labels Jun 10, 2024
@anomiex anomiex requested a review from a team June 10, 2024 19:32
@anomiex anomiex self-assigned this Jun 10, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Copy link
Contributor

github-actions bot commented Jun 10, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/pnpm-9.3.0 branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/pnpm-9.3.0
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/pnpm-9.3.0
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@anomiex anomiex merged commit 2d2a396 into trunk Jun 10, 2024
76 checks passed
@anomiex anomiex deleted the update/pnpm-9.3.0 branch June 10, 2024 20:43
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jun 10, 2024
dilirity pushed a commit that referenced this pull request Jun 11, 2024
Last week we updated from pnpm 8 to pnpm 9.2.0, and then today they
released 9.3.0 with a change in the lock file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants