Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update social previews package #36874

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Conversation

manzoorwanijk
Copy link
Member

Fixes https://github.com/Automattic/jetpack-reach/issues/228
Related Automattic/wp-calypso#89483

Proposed changes:

  • Update @automattic/social-previews package to the latest beta

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • For a Jetpack site with Jetpack Advanced plan, create a post.
  • Open Jetpack or Social sidebar and add custom media (photo/video)
  • Enable "Share as a social post"
  • Open Social Previews
  • Goto Mastodon section
  • Confirm that the "Your post" is displayed as a media post and not as link preview
  • Now uncheck "Share as a social post"
  • Open Social Previews again
  • Goto Mastodon section
  • Confirm that the "Your post" is displayed as link preview

@manzoorwanijk manzoorwanijk added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Apr 12, 2024
@manzoorwanijk manzoorwanijk requested a review from a team April 12, 2024 12:02
@manzoorwanijk manzoorwanijk self-assigned this Apr 12, 2024
@github-actions github-actions bot added [JS Package] Publicize Components [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA labels Apr 12, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for May 7, 2024 (scheduled code freeze on May 6, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social-previews-package branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/social-previews-package
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/social-previews-package
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, next time you could probably go to #23363 and check the box for @automattic/social-previews to have Renovate do the work for you (then use the link at the bottom to find how to trigger an immediate run if you don't want to wait for it). Then all you'd need to do is review and merge it.

@manzoorwanijk manzoorwanijk merged commit 34bfb38 into trunk Apr 12, 2024
70 of 72 checks passed
@manzoorwanijk manzoorwanijk deleted the update/social-previews-package branch April 12, 2024 14:50
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Apr 12, 2024
@github-actions github-actions bot added this to the jetpack/13.4 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] Publicize Components [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants