-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect: Add WAF StatCards #35739
Protect: Add WAF StatCards #35739
Conversation
…rd components to firewall header
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
fb52e10
to
4235055
Compare
4235055
to
c27aeac
Compare
1e6e62e
to
f573cdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
* Add waf stats class blocked requests stats actions, and apply stat card components to firewall header * Adjust approach for storing and retrieving stats * changelog * Fix phpcs enables * Remove FirewallHeader stories edits * Use options over an additional table * Reorg and fix spacing * Fix dynamic/static calls * Make update_daily_summary public for tests * use deprecated setMethods over onlyMethods to bypass PHP 7.0 project test failures * Fix up project versions * Disable summary updates if share data is disabled, and add conditions to stat card display * Remove TODOs * Improve changelog entries * Restructuring, improvements, storybook fixes * Make use of static methods consistent * Add standalone mode handling for update_daily_summary * Fix tests * Add integration tests * Revert unit test removal * Fix naming * Fix project versions * Fix versions * Remove IDC package * Remove duplicate changelog entries * Revert vscode settings.json changes * changelog * Undo wpcomsh plugin updates * Revert prior changes to wpcomsh * Fix versions * Optimize FirewallStatCards * Fix share data option check * Fix styling * Fix translation strings * Ensure no duplicated code and extra debug data is logged appropriately * Fix tests * Fix phan errors * Use supported phpunit method * Use supported phpunit method * Final test fixes * Remove unused code, add plan check for new stats * Fix method naming * Add method for retrieving all time stats * Make direct db connection persistent, add/fix tests * Close db connection if initialized * Add standalone mode direct db handling * Fix project versions * Ignore phpcs rules, data needs to be current * Remove error_log * Address phan errors * Use standard approach * Add update flag to initialization method so we aren't duplicating the action * Fix initialization method calls * Manually update phan baselines * Revert versions updates * Remove duplicate changelog entries * Remove FirewallHeader stories from broken dir * Update stories * Updates to Blocklog Manager class * Fix prop name * Minor enhancements and compatibility improvements * Statcard adjustments * Revert phan baselines changes * Reapply phan baseline changes * Apply naming consistency, update FirewallSubheading to use IconTooltip * Fixes --------- Co-authored-by: Nate Weller <[email protected]>
Description
Proposed changes:
StatCard
js-packages component easily accessibleWaf_Blocklog_Manager
class and migrates related methods overjetpack_waf_blocklog_daily_summary
, andjetpack_waf_all_time_stats
optionsStatCard
components to theFirewallHeader
and hooks up the new statsOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
$date
value in theupdate_daily_summary()
method of theWaf_Blocklog_Manager
class to simulate requests from a different day within the same month and from outside of the current monthjetpack_waf_blocklog_daily_summary
, andjetpack_waf_all_time_stats
option data and stats in the UI reflect the entries and that any data logged outside of the current month is prunedjetpack-waf/waf-blocklog
entries orjetpack_waf_blocklog_daily_summary
, andjetpack_waf_all_time_stats
option updates are made when share data is disabled (note thatwp_jetpack_waf_blocklog
table entries will continue as well)cd projects/js-packages/storybook && npm run storybook:dev
and verify that all ProtectFirewallHeader
stories renderjetpack test packages/waf php
to ensure that all integration tests passScreenshots:
Desktop:
Mobile: