Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monorepo to Composer 2.7.1 #35574

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Update monorepo to Composer 2.7.1 #35574

merged 1 commit into from
Feb 9, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Feb 9, 2024

Proposed changes:

Apparently 2.7.0 fixed a security bug, so people want this updated sooner rather than later.

Fortunately there's no API version change this time around so no lock files need updating.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1707492835678279-slack-C05Q5HSS013
Announcement draft: pdWQjU-HJ-p2

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Everything still work?
  • In particular, let's make sure CI Build and Test actually ran and passed.

Apparently 2.7.0 fixed a security bug, so people want this updated
sooner rather than later.

Fortunately there's no API version change this time around so no lock
files need updating.
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Feb 9, 2024
@anomiex anomiex requested a review from a team February 9, 2024 17:14
@anomiex anomiex self-assigned this Feb 9, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/composer branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/composer
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/composer
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Feb 9, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best composer update ever! :)

@anomiex anomiex merged commit 2aa6a63 into trunk Feb 9, 2024
70 checks passed
@anomiex anomiex deleted the update/composer branch February 9, 2024 17:38
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 9, 2024
spsiddarthan pushed a commit that referenced this pull request Feb 15, 2024
Apparently 2.7.0 fixed a security bug, so people want this updated
sooner rather than later.

Fortunately there's no API version change this time around so no lock
files need updating.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants