Skip to content

Commit

Permalink
Performance: change default imploding to false
Browse files Browse the repository at this point in the history
  • Loading branch information
kraftbj committed Sep 22, 2024
1 parent 20eab85 commit e489b3e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/remove-imploding-css
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: enhancement

Performance: set the concatenated CSS to false by default. The era where this was helpful is passing.
3 changes: 2 additions & 1 deletion projects/plugins/jetpack/class.jetpack.php
Original file line number Diff line number Diff line change
Expand Up @@ -5688,9 +5688,10 @@ public static function absolutize_css_urls( $css, $css_file_url ) {
* @param bool $travis_test Is this a test run.
*
* @since 3.2
* @since $$next-version$$ Default to not imploding. Requires a filter to enable. This may be temporary before dropping completely.
*/
public function implode_frontend_css( $travis_test = false ) {
$do_implode = true;
$do_implode = false;
if ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) {
$do_implode = false;

Check failure on line 5696 in projects/plugins/jetpack/class.jetpack.php

View workflow job for this annotation

GitHub Actions / Static analysis

Plugin PhanPluginRedundantAssignment Assigning false to variable $do_implode which already has that value
}
Expand Down

0 comments on commit e489b3e

Please sign in to comment.