-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Remove <title> tags from SVGs #207
Conversation
I'm a bit uncomfortable with To test, I checked:
Note: I had to run |
@bluefuton can you drop a quick eye here on the code to have a more expert review? Should be quick :) |
Thanks @mladenplavsic! Code looks good to me - just needs rebasing and SVGs regenerating I think 👍 |
Conflicts: docs/gridicons.svg svg-sprite/gridicons.svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
@mladenplavsic feel free to squash and merge. |
@drw158 I would like to, but I don't have permission for it :-) |
I'll do the honours. Thanks @mladenplavsic! |
As described in #205 <title> tags are removed in these usages of SVG:
This is done by updating
Gruntfile.js
- removed "addtitle" task.Some more things done:
grunt-svgstore
to version1.0.0
inpackage.json
includeTitleElement
and set tofalse
https://github.com/fweinb/grunt-svgstore#optionsincludetitleelement-since-050prefix
svg-min/*.svg
instead ofsvg/*.svg
for "svgstore" task