Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSUSD-1975 - Optimize material libraries #4055

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

JGamache-autodesk
Copy link
Collaborator

Allow deep library optimization ff a user introduces a material library that has nodes implemented via NodeGraph that embed optimizable nodes.

Also fixed issues encountered while dealing with MaterialX namespaces.

Allow deep library optimization ff a user introduces a material library that has nodes implemented via
NodeGraph that embed optimizable nodes.

Also fixed issues encountered while dealing with MaterialX namespaces.
Copy link
Collaborator

@frohnej-adsk frohnej-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I added some thoughts on improving readability, but I'm not sure if all of it is possible or makes sense.

lib/mayaUsd/render/MaterialXGenOgsXml/LobePruner.h Outdated Show resolved Hide resolved
lib/mayaUsd/render/MaterialXGenOgsXml/LobePruner.cpp Outdated Show resolved Hide resolved
lib/mayaUsd/render/MaterialXGenOgsXml/LobePruner.cpp Outdated Show resolved Hide resolved
lib/mayaUsd/render/MaterialXGenOgsXml/LobePruner.cpp Outdated Show resolved Hide resolved
frohnej-adsk
frohnej-adsk previously approved these changes Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants