Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix add account issue #1264

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix add account issue #1264

merged 1 commit into from
Aug 22, 2024

Conversation

Sneezry
Copy link
Member

@Sneezry Sneezry commented Aug 21, 2024

Fix #1262

@Sneezry Sneezry requested a review from mymindstorm August 21, 2024 12:09
mymindstorm
mymindstorm requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@mymindstorm mymindstorm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore previous comments.

Instead of making OTPEntry have multiple encryptions (we need to maintain a 1:1 relationship between an OTPEntry and an encryption), make

https://github.com/Authenticator-Extension/Authenticator/blob/dev/src/components/Popup/AddAccountPage.vue#L131

pass state.accounts.defaultEncryption instead.

@Sneezry Sneezry force-pushed the zhe/fixaddaccount branch from c6088f9 to 7e03c80 Compare August 21, 2024 22:37
@Sneezry
Copy link
Member Author

Sneezry commented Aug 21, 2024

Updated

@Sneezry Sneezry merged commit 6ae872d into dev Aug 22, 2024
10 checks passed
@Sneezry Sneezry deleted the zhe/fixaddaccount branch August 22, 2024 05:09
Sneezry added a commit that referenced this pull request Aug 23, 2024
@Sneezry @mymindstorm
v8.0.1 (#1272)
cf71a63 
* fix issue in translations

* fix add account issue (#1264)

* v8.0.1 (#1270)

---------

Co-authored-by: Brendan Early <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mymindstorm mymindstorm mymindstorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding new accounts with manual entry is broken
2 participants
@Sneezry @mymindstorm