Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require verifying password before chaning it #1246

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

mymindstorm
Copy link
Member

I plan to make another PR to deduplicate password verification and hashing code.

@mymindstorm mymindstorm requested a review from Sneezry July 29, 2024 02:41
src/models/password.ts Dismissed Show dismissed Hide dismissed
this.currentPhrase
);
if (!isCorrectPassword) {
this.$store.commit("notification/alert", this.i18n.phrase_not_match);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should distinguish between the situations where the user has entered an incorrect current password and where the two new passwords do not match, to avoid causing confusion for the user.

@mymindstorm mymindstorm requested a review from Sneezry July 30, 2024 05:11
@mymindstorm mymindstorm merged commit 15667ec into dev Aug 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants