Implement work-around/fix for incorrect render of manually added HOTP tokens #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tokens The parsed `<option>` returns the OTP.type in string value, instead of the required integer type. Later in execution, the code can't handle the string in comparisons, etc. This just parseInts the string so that it's correctly handled.
|
Could you fix the CI issue and manually test the changes? |
Given the issue derives from the `option`s returning the value as a string by default, the 'number' modifier typecasts the value as a number. This then correctly flows on to the script execution https://v2.vuejs.org/v2/guide/forms.html
|
I've updated the patch according to commit notes; essentially in order to return an integer, a Have tested and compiled successfully. |
mymindstorm
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parsed
<option>returns the OTP.type as a string, instead of the required integer type. Later in execution, the code can't handle the string in comparisons, etc.As a result, selecting a different type causes the resulting entry to be handled as a standard TOTP type. Giving it the appearance and behaviour as such - it also affects backups (..
&counter=undefined) if done so in the same session.Any type of operation apart from the default type (as that's assigned an integer by default) with the option is affected.
In saying that, once reloaded, some other part of the code corrects the entry and storage.
This just parseInts the string so that it's correctly handled.
You might have some better way of doing this, perhaps earlier on, etc.