Pull request to fix issue #12 for 0 values in np.log10() #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are zero values in the spectrogram array (the intensity is null) the np.log10 raises an Error (because log10(0) = -inf). Because the log10 is used to reduce the range of the values, when a value is zero, zero should be returned.
…Error" This reverts commit a1c66e2.
When there are zero values in the spectrogram array (the intensity is null) the np.log10 raises an Error (because log10(0) = -inf). Because the log10 is used to reduce the range of the values, when a value is zero, zero should be returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue caused errors when processing sounds with silent segments.
Because the logarithm is used to weight the samples, it is my understanding that replacing log(0) values with 0 would
not reduce the model's accuracy.