fix: React warnings

Atry · Feb 1, 2023 · 70afb97 · 70afb97
1 parent 144716d
commit 70afb97
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/BindingHtmlToReact/src/main/scala/com/yang_bo/BindingHtmlToReact.scala b/BindingHtmlToReact/src/main/scala/com/yang_bo/BindingHtmlToReact.scala
@@ -40,16 +40,18 @@ object BindingHtmlToReact extends ComponentWrapper {
       }
     }
 
-    def current_=(wrapperElement: Element): Unit = {
+    def setter: js.Function1[Element, Unit] = { wrapperElement =>
       wrapperVar.value = Some(wrapperElement)
     }
+
     def initialState = ()
 
     def render() =
-      props.wrapper(this.asInstanceOf[ReactRef[Node with ParentNode]])
-    override def componentWillMount(): Unit = {
+      props.wrapper(setter.asInstanceOf[ReactRef[Node with ParentNode]])
+
+    override def componentDidMount(): Unit = {
+      super.componentDidMount()
       mountPoint.watch()
-      super.componentWillMount()
     }
 
     override def componentWillUnmount(): Unit = {

diff --git a/BindingReactToReact/src/main/scala/com/yang_bo/BindingReactToReact.scala b/BindingReactToReact/src/main/scala/com/yang_bo/BindingReactToReact.scala
@@ -85,9 +85,9 @@ object BindingReactToReact extends ComponentWrapper {
 
     def render(): ReactElement = state
 
-    override def componentWillMount(): Unit = {
+    override def componentDidMount(): Unit = {
+      super.componentDidMount()
       setterBinding.watch()
-      super.componentWillMount()
     }
 
     override def componentWillUnmount(): Unit = {