Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rectangular matrix support for FullPivLu #164

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/matrix/base/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,17 @@ pub trait BaseMatrix<T>: Sized {
/// Row stride in the matrix.
fn row_stride(&self) -> usize;

/// Returns true if the matrix contais no elements
/// Returns true if the matrix contains no elements
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

fn is_empty(&self) -> bool {
self.rows() == 0 || self.cols() == 0
}

/// Returns true if the matrix has the same number of
/// rows as columns.
fn is_square(&self) -> bool {
self.rows() == self.cols()
}

/// Top left index of the matrix.
fn as_ptr(&self) -> *const T;

Expand Down
Loading