Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization and Localization in Luminol #29

Closed
wants to merge 12 commits into from
Closed

Conversation

somedevfox
Copy link
Collaborator

No description provided.

@somedevfox somedevfox requested a review from melody-rs July 10, 2023 10:40
@melody-rs
Copy link
Member

I'd like to put this pull request on hold until new-tilemap is merged as this branch is based on it

src/filesystem.rs Outdated Show resolved Hide resolved
@melody-rs
Copy link
Member

A rebase of this branch is needed due to the merging of #43

@melody-rs melody-rs added the enhancement New feature or request label Oct 6, 2023
somedevfox and others added 12 commits October 6, 2023 12:47
What changed:
 - [rfd]: Pull strategy moved from downloading a version from crates.io to a github repository hosted by somedevfox
 - [i18n-embed]: Added; Provides localization APIs
 - [i18n-embed-fl]: Added; Compiler-time checks for `i18n-embed`
 - [locale-codes]: Added, temporarily; For getting native language names by their codes
 - [rust-embed]: Added; For embedding whole file directories into the app's executable

Why?
 - Current version of `rfd` provides methods which accept only `&str` string types, while sdf's repository accepts anything that implements `ToString`
 - i18n-embed, i18n-embed-fl and locale-codes have been added for translating Luminol to other languages
 - rust-embed has been added to store language directories inside the application to prevent I/O errors if we were to request actual files

feat: whoopsies forgot to upload the lock file
What changed:
 - [i18n]: Added; Module for handling internationalization and localization tasks
 - [i18n::LOADER]: Added; Language loader powered by Fluent Framework
 - [i18n::language_loader]: Added; Returns a static ref to the LOADER
 - [i18n::set_language]: Added; Switches current active language in the LOADER
 - [i18n::fl]: Added; Macro which returns the translated strings and also checks for tokens' existence compile-time
Notes:
 - en-AU is considered the main and a fallback language in Luminol
 - en-AU is an ISO 639-1 code for the Australian Dialect of English Language, also shown in UIs as "English (Australian)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants