Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify user interface crates #154

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Unify user interface crates #154

merged 1 commit into from
Aug 22, 2024

Conversation

somedevfox
Copy link
Collaborator

Connections
None

Description
Luminol's user interface is rendered by three separate crates: ui, modals and components. It never made much sense to me, since all of them handle the same task. This pull request unifies these crates.

Testing

  • Run cargo run or trunk run (depending on desired platform) and open the About... window.

Additionally, I have measured compilation times between the dev and my branches by running cargo build in both. Both took the same amount of time to compile.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown -Z build-std=std,panic_abort
  • Run cargo build --release
  • If applicable, run trunk build --release

@somedevfox somedevfox requested a review from a team as a code owner August 21, 2024 18:33
Copy link
Collaborator

@white-axe white-axe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please fix the "Build Trunk" build workflow at some point so that it actually uploads the web build to GitHub

@somedevfox
Copy link
Collaborator Author

Oh, I didn't know it was broken. Thank you for telling me.

Copy link
Member

@melody-rs melody-rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's actually a reason why all of these crates were separate- I intended components and modals to be very general and unable to create tabs and windows.

Tabs and windows were combined into the same crate simply because of the MapInfos window- it needed to be able to create the map tab.

@melody-rs
Copy link
Member

melody-rs commented Aug 22, 2024

Looks good but please fix the "Build Trunk" build workflow at some point so that it actually uploads the web build to GitHub

I'll go ahead and fix this

@melody-rs melody-rs merged commit 9a76303 into Astrabit-ST:dev Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants