Reorganise the main crate and move it to crates/ #153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
None
Description
The main crate of Luminol is unnecessarily convoluted. The entry point file (
src/main.rs
) contains initialisation instructions for both native and web platforms and, consequentially, a lot of#[cfg(target_arch)]
macros. They're an eye sore and make the file difficult to navigate at times.Additionally, when we started the Luminol project, we couldn't initialise the main crate in the
crates
directory, because one of the dependencies required us to place it into the root directory of the git repository. This is no longer a case, as Trunk can be configured to compile theindex.html
file in a different directory.Testing
cargo run
and open any project.trunk run
and open any project (in Chromium-based browsers).Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown -Z build-std=std,panic_abort
cargo build --release
trunk build --release