Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise the main crate and move it to crates/ #153

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

somedevfox
Copy link
Collaborator

@somedevfox somedevfox commented Aug 20, 2024

Connections
None

Description
The main crate of Luminol is unnecessarily convoluted. The entry point file (src/main.rs) contains initialisation instructions for both native and web platforms and, consequentially, a lot of #[cfg(target_arch)] macros. They're an eye sore and make the file difficult to navigate at times.

Additionally, when we started the Luminol project, we couldn't initialise the main crate in the crates directory, because one of the dependencies required us to place it into the root directory of the git repository. This is no longer a case, as Trunk can be configured to compile the index.html file in a different directory.

Testing

  • Run cargo run and open any project.
  • Run trunk run and open any project (in Chromium-based browsers).

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown -Z build-std=std,panic_abort
  • Run cargo build --release
  • If applicable, run trunk build --release

@somedevfox somedevfox requested a review from a team as a code owner August 20, 2024 11:29
@somedevfox somedevfox requested a review from white-axe August 20, 2024 16:17
@melody-rs melody-rs merged commit 2165b80 into Astrabit-ST:dev Aug 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants