Update egui to 0.28.1 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems we are now required to use a version of `wasm-bindgen-futures` that won't compile with Rust nightly versions older than 2024-02-06, so I upgraded the Rust toolchain to 2024-05-19, the latest version that works without encountering an unrelated compilation error in the `time` crate.
This is to make it look consistent with how it was before the egui update.
This fixes the displaying of the icon in the "About" window.
The release notes for eframe 0.28.0 say you need to focus the canvas on startup if you're creating a fullscreen app.
|
Seems to run way more choppy now, even in release? 2024-07-22.14-51-09.mp4 |
|
Performance is the same as it was before on my computer. Maybe wgpu changed how it configures graphics drivers by default? |
melody-rs
approved these changes
Jul 22, 2024
MolassesLover
pushed a commit
to MolassesLover/luminol-molasses
that referenced
this pull request
Jul 23, 2024
* Merge from upstream egui 0.28.1 * Update everything else and fix compilation errors It seems we are now required to use a version of `wasm-bindgen-futures` that won't compile with Rust nightly versions older than 2024-02-06, so I upgraded the Rust toolchain to 2024-05-19, the latest version that works without encountering an unrelated compilation error in the `time` crate. * Fix another release-mode-only compilation error * Fix `BorrowMutError` in web builds * Make IME work again in web builds * Fix compiler warnings * Add spacing at the bottom of the map editor top bar This is to make it look consistent with how it was before the egui update. * Fix doc comment in crates/eframe/src/lib.rs * Update `image` from 0.24 to 0.25 This fixes the displaying of the icon in the "About" window. * Remove eframe text agent after panic in web builds * Focus the HTML canvas on startup in web builds The release notes for eframe 0.28.0 say you need to focus the canvas on startup if you're creating a fullscreen app. * Fix terminal scroll delta calculation when unit is pages * Fix compiler warning in steam.rs
MolassesLover
pushed a commit
to MolassesLover/luminol-molasses
that referenced
this pull request
Jul 23, 2024
* Merge from upstream egui 0.28.1 * Update everything else and fix compilation errors It seems we are now required to use a version of `wasm-bindgen-futures` that won't compile with Rust nightly versions older than 2024-02-06, so I upgraded the Rust toolchain to 2024-05-19, the latest version that works without encountering an unrelated compilation error in the `time` crate. * Fix another release-mode-only compilation error * Fix `BorrowMutError` in web builds * Make IME work again in web builds * Fix compiler warnings * Add spacing at the bottom of the map editor top bar This is to make it look consistent with how it was before the egui update. * Fix doc comment in crates/eframe/src/lib.rs * Update `image` from 0.24 to 0.25 This fixes the displaying of the icon in the "About" window. * Remove eframe text agent after panic in web builds * Focus the HTML canvas on startup in web builds The release notes for eframe 0.28.0 say you need to focus the canvas on startup if you're creating a fullscreen app. * Fix terminal scroll delta calculation when unit is pages * Fix compiler warning in steam.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates egui to 0.28.1 and wgpu to 0.20.1.
In web builds, wgpu now requires a version of wasm-bindgen-futures that won't compile with Rust nightly toolchain versions earlier than 2024-02-06 if the +atomics compiler feature is enabled, so I updated the Rust toolchain to 2024-05-19, the latest nightly version that I could get all of our dependencies to compile with.
Make sure to update the toolchain version for luminol-website as well or it won't build anymore after this pull request.
Testing
I checked that the following things still work in native and web builds:
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown -Z build-std=std,panic_abortcargo build --releasetrunk build --release