[WIP] Event editor #135
Merged
[WIP] Event editor #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was annoying and probably not needed
white-axe
requested changes
Jul 2, 2024
It was just technical debt, back from when Window deduplication was by Window::name instead of Window::id
white-axe
requested changes
Jul 4, 2024
white-axe
approved these changes
Jul 4, 2024
MolassesLover
pushed a commit
to MolassesLover/luminol-molasses
that referenced
this pull request
Jul 23, 2024
* forget outputstream, making audio send+sync * Port over modals from old branch * add basic event editor window * Fix modal id conflict * Use unified modal * Replace import hack * Add most of the event ui * start implementing the graphic picker * Add picker window * Display graphic picker options * Add sorta working tilepicker * More picker stuff * More picker things * Hue & Opacity editing * Fix some display issues * adjust layout * Show stripes * Add search and fix stripes * Actually save the graphic * Insert events * Minor fixes * Validate texture sizes * Fix fmt errors * Make preview sprite loading more fallible * Grey out invalid sprites * Fix preview sprite handling * Properly handle sprite scrolling * Load from RTP on native too * Properly load RTPs this time * Don't enable debug symbols in release * Remove all nightly features * Update readme * Clean up soundtab * cache sound tab results * Cache filters * Use rows for graphic picker * Re-add stripes to graphic picker * Remove first open * Very destructive commit Not very happy with this because it clones things, which is a waste of memory * Revert "Very destructive commit" This reverts commit 471b014. * Only load directory entries on modal opening * Pad out top bar of event editor & graphic picker * Use cross justify to expand the trigger window * Fmt * mem::take data from update state so we can use it in database view * Add menu use se modal to item editor * Use get_mut instead of borrow() in Data::save() * Clean up sound picker modal a little * Only load tilepicker when selecting tiles * work on the graphic picker a bit * Make Modal::reset actually useful * Add graphic picker to item editor * Fill out graphic picker more * Make modals take data by value (might revert this) * Remove ResetData Was annoying and probably not needed * Move current graphic picker into "basic" * Add hue picker * Deduplicate graphic picker behaviour * Move event graphic picker into graphic_picker/ * Deduplicate more things * Hack in the enemy battler picker * add hacky actor graphic picker * Directly* edit events * Remove Window::name It was just technical debt, back from when Window deduplication was by Window::name instead of Window::id * Fix AudioFile::default defaulting to 0 volume * Bump rodio version (fixes sound test crash?) * Fix compiler warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
N/A
Description
This reimplements (part of) the event editor, as well as the picker modals! (Switch, Variable, Graphic, etc) I added some temporary test modals into the item and actor editor to show off that they work.
There isn't any event command editor yet though- That's reserved for another PR. I'm still working out the details of the event command editor. Same goes for Undo/Redo as well.
Testing
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown -Z build-std=std,panic_abortcargo build --releasetrunk build --release