Implement saving map as image file #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where when the size of the map editor changes, the grid shader's internally stored value for the size of the map editor's viewport doesn't get updated until one frame later if the shader is using push constants. This caused the thicknesses of the grid lines to be inaccurate for a frame after resizing.
melody-rs
approved these changes
Jun 15, 2024
MolassesLover
pushed a commit
to MolassesLover/luminol-molasses
that referenced
this pull request
Jul 23, 2024
* fix: fix 1 frame delay when grid shader viewport size changes This fixes a bug where when the size of the map editor changes, the grid shader's internally stored value for the size of the map editor's viewport doesn't get updated until one frame later if the shader is using push constants. This caused the thicknesses of the grid lines to be inaccurate for a frame after resizing. * feat: add "Save map preview" button for saving map as image * style: replace `ScreenshotState` with an async block * perf: don't use padding in the texture when screenshotting * feat: handle screenshotting for maps larger than max texture size * fix: fix `width_padded` alignment value * style: remove unnecessary rounding from `max_texture_width`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a "Save map preview" button to the map editor that saves the current state of the map, with all currently visible layers, as a PNG file.
The implementation is in the
save_as_imagefunction in crates/components/src/map_view.rs.Testing
On an arbitrary map, the button should be able to correctly render all visible map layers and events, with layer darkening if it's enabled. Also it should be able to render the grid and collision layers if they're enabled. It should also be able to render maps that are larger than the maximum texture dimensions allowed by wgpu (it does this by breaking the map into large tiles and rendering them individually before combining them together).
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown -Z build-std=std,panic_abortcargo build --releasetrunk build --release