Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change drag events in the map editor into pointer down events #118

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

white-axe
Copy link
Collaborator

Connections

Description
This pull request changes the trigger for drawing tiles on the map and for selecting tiles in the tilepicker from dragging the mouse to just having the primary mouse button down. This allows tiles to be drawn/selected immediately when the primary mouse button is down instead of requiring the user to move the mouse slightly.

Testing
It should no longer be required to drag the mouse slightly for tile drawing/selection to be triggered, although they should still trigger when dragging the mouse. In addition, they should still only trigger when the primary mouse button is down rather than any mouse button.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown -Z build-std=std,panic_abort
  • Run cargo build --release
  • If applicable, run trunk build --release

@white-axe white-axe requested a review from a team as a code owner March 23, 2024 16:25
@melody-rs melody-rs merged commit d51aa4a into Astrabit-ST:dev Mar 25, 2024
5 checks passed
@white-axe white-axe deleted the drag-fix branch March 25, 2024 15:05
@white-axe white-axe restored the drag-fix branch March 25, 2024 15:05
@white-axe white-axe deleted the drag-fix branch March 25, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Clicking on tiles in the map view or tilepicker doesn't select/edit tiles
2 participants