Replace missing textures with a placeholder #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There will still be toasts for missing textures, but now maps with missing textures will load with placeholder textures instead of refusing to open.
This changes the toasts to show the most recent one at the top so that long strings of errors will show properly.
melody-rs
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
This pull request allows maps to load if there are missing textures. There will be a toast for each missing texture, which will be replaced by the black and magenta checkerboard pattern at crates/graphics/data/placeholder.png.
The toasts have also been changed to display the most recent toast at the top instead of at the bottom so that new toasts are still visible after long sequences of toasts.
Testing
Maps should now load even if the entire Graphics folder is removed from a project.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo build --releasetrunk build --release