Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding source objects will be added in
ScopeSim_Templates
.I ended up splitting the "upstream stuff" (i.e. location and telescope) into a separate mode, for now called "light". I'm open to better name suggestions, the reason I choose "light" was because I know the term "light frame" for anything that observes "through the telescope" (like actual observations, but also things like dome flats) as opposed to "dark frame" without the telescope in the optical path.
The reason for splitting this in the first place (and not just adding the two yamls to all other modes like I did in my first attempt) as that the WCU mode will need to work for multiple different instrument modes (image, lss, ifu, ...) and so the other option would have been separate modes "wcu_img_n", "wcu_img_lm", "wcu_lss_n", etc etc etc. The split is also similar in concept to the SCAO/MCAO + "actual mode" split in MICADO.
I realize that might break some existing code which doesn't explicitly set the new "ligth" mode yet (although the default does). For the time being, a temporary "solution" might be to keep this change in a "dev" version of the METIS IRDB package (that's fully supported after all), so the default
sim.download_packages
will still have the old mode...