Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WCU mode to METIS #166

Draft
wants to merge 5 commits into
base: dev_master
Choose a base branch
from
Draft

Add WCU mode to METIS #166

wants to merge 5 commits into from

Conversation

teutoburg
Copy link
Contributor

@teutoburg teutoburg commented Apr 3, 2024

The corresponding source objects will be added in ScopeSim_Templates.

I ended up splitting the "upstream stuff" (i.e. location and telescope) into a separate mode, for now called "light". I'm open to better name suggestions, the reason I choose "light" was because I know the term "light frame" for anything that observes "through the telescope" (like actual observations, but also things like dome flats) as opposed to "dark frame" without the telescope in the optical path.

The reason for splitting this in the first place (and not just adding the two yamls to all other modes like I did in my first attempt) as that the WCU mode will need to work for multiple different instrument modes (image, lss, ifu, ...) and so the other option would have been separate modes "wcu_img_n", "wcu_img_lm", "wcu_lss_n", etc etc etc. The split is also similar in concept to the SCAO/MCAO + "actual mode" split in MICADO.

I realize that might break some existing code which doesn't explicitly set the new "ligth" mode yet (although the default does). For the time being, a temporary "solution" might be to keep this change in a "dev" version of the METIS IRDB package (that's fully supported after all), so the default sim.download_packages will still have the old mode...

This allows a future calibration mode to ignore them without any hacks.
@teutoburg teutoburg added enhancement New feature or request instrument-specific Limited to a certain IRDB instrument package labels Apr 3, 2024
@teutoburg teutoburg self-assigned this Apr 3, 2024
@teutoburg teutoburg linked an issue Apr 3, 2024 that may be closed by this pull request
@hugobuddel
Copy link
Collaborator

Good work!

(Next commit: "refactor the different modes into separate yaml files". Commit after that "rename the yaml files to match names of observing templates". 🦝. j/k, we should just YAGNI al that, and right now we need this new mode, let's see where it ends up.)

@teutoburg
Copy link
Contributor Author

Tests are failing because the new WCU mode produces an error when the FITS header effects try to access an (obviously now nonexistent) telescope_reflection property. This is a simply fix in ScopSim which I'll prepare and then link to this PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request instrument-specific Limited to a certain IRDB instrument package
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

METIS WCU calibration mode
2 participants