Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tplstart values #71

Closed
wants to merge 2 commits into from
Closed

Fix tplstart values #71

wants to merge 2 commits into from

Conversation

JenniferKarr
Copy link
Contributor

made the tplstart values more reasonable - they now match the observtion date.

fixed a wrong template value in recipes.yaml

regenerated the data based on these values and regenerated checksums.

@hugobuddel
Copy link
Contributor

All exposures from the same template should have the same TPL.START; is that the case with this PR?

In particular, the ESO stack (EDPS) by default groups data on TPL.START. So for example to (automatically) stack 10 raw darks into a master dark, then all raw darks should have the same TPL.START. (It is also possible to define different grouping rules, but we can stick to the default most of the time.)

@JenniferKarr
Copy link
Contributor Author

At the moment, almost all the files have a single image per template (the minimum set needed for workflow generation); the exception is pairs of sci/std and sky (which for the time being have the same tpl.start). We don't currently consider template structure in the METIS_Simulations code, so implementing that will take a bit of thought and will not be done for Friday. The current state is more plausible than it was a couple of hours ago, however, when all the tpl.start values were identical.

@hugobuddel
Copy link
Contributor

OK good, if we have only one file per template anyway, then this is fine. I see you fixed this in #73 so I'll close this, thanks!

@hugobuddel hugobuddel closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants