Added tplname to recipes.yaml to vary the templates in the headers #44
Conversation
… the simulated data.
Currently it fails with IFU_SKY_RAW has tplname metis_ifu_cal_standard but only ['metis_ifu_obs_fixedskyoffset', 'metis_ifu_obs_genericoffset', 'metis_ifu_ext_obs_fixedskyoffset', 'metis_ifu_ext_obs_genericoffset', 'metis_ifu_vc_obs_fi xedskyoffset', 'metis_ifu_ext_vc_obs_fixedskyoffset', 'metis_ifu_app_obs_stare', 'metis_ifu_ext_app_obs_stare', 'metis_ifu_cal_psf'] create it
There was a problem hiding this comment.
Thank you @gotten ! I've found an inconsistency with the DRLD, but I believe it is the DRLD that is wrong, so let's get this merged.
| @@ -845,6 +876,7 @@ IFU_SKY_RAW2: | |||
| mjdobs: | |||
| - 2024-01-02 04:48:10 | |||
| - 2024-01-02 04:48:20 | |||
| tplname: "METIS_ifu_cal_standard" | |||
There was a problem hiding this comment.
I've added a check to verify whether the tplnames are consistent with the DRLD, see #45, (which merges into this branch BTW).
Apparently IFU_SKY_RAW is not created by METIS_ifu_cal_standard according to the DRLD. I think the DRLD is wrong.
There was a problem hiding this comment.
I think it might be an inconsistency in the yaml as commented on by the comment in the code. The previous entry is an IFU_STD_RAW and this one is an IFU_SKY_RAW. I was a bit on automatic pilot while adding the tplnames and was under the impression that these files are copies of eachother with noise redrawn (and different timestamp).
There was a problem hiding this comment.
The metis_ifu_reduce is the only recipe with IFU_SKY_RAW as optional input, and the recipes lists 10 templates which data it can process. However, IFU_SKY_RAW only lists 9 of those templates. So it seems you just selected the one template that we forgot to add there.
There was a problem hiding this comment.
Note that the other *_SKY_RAW files are not mentioned in the DRLD at all, as discussed in #37.
See the comment in #44 , it might be an issue with how I interpreted the yaml. I'm OK with the changes described here.
I updated the recipes.yaml file with tplname entries based on the DRLD. A test run with --small True is running. So far (25% done) the files look OK.
Closes #32