Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename metis_lm_basic_reduce to metis_lm_img_basic_reduce #61

Merged
merged 1 commit into from
Nov 14, 2024
+7 −7
Merged

Rename metis_lm_basic_reduce to metis_lm_img_basic_reduce #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/run_edps.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
pyesorex metis_lm_img_flat "${SOF_DIR}/metis_lm_img_flat.lamp.sof"
cat "${SOF_DIR}/metis_lm_img_basic_reduce.sof"
# TODO: This recipe name is incorrect and should be renamed
pyesorex metis_lm_basic_reduce "${SOF_DIR}/metis_lm_img_basic_reduce.sof"
pyesorex metis_lm_img_basic_reduce "${SOF_DIR}/metis_lm_img_basic_reduce.sof"
- name: Run EDPS
run: |
# . metispipe/bin/activate
Expand All @@ -60,5 +60,5 @@ jobs:
export SOF_DIR="$(pwd)/METIS_Pipeline_Test_Data/metis_sim_small_1/sof"
edps -lw
edps -w metis.metis_lm_img_wkf -i $SOF_DATA -c
edps -w metis.metis_lm_img_wkf -i $SOF_DATA -t metis_lm_basic_reduce | tee edps.stdout.txt
edps -w metis.metis_lm_img_wkf -i $SOF_DATA -t metis_lm_img_basic_reduce | tee edps.stdout.txt
! grep "'FAILED'" edps.stdout.txt
2 changes: 1 addition & 1 deletion metisp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Running one specific recipe
edps -w metis.metis_lm_img_wkf -i $SOF_DATA -t metis_det_detlin
edps -w metis.metis_lm_img_wkf -i $SOF_DATA -t metis_det_dark
edps -w metis.metis_lm_img_wkf -i $SOF_DATA -t metis_lm_img_flat
edps -w metis.metis_lm_img_wkf -i $SOF_DATA -t metis_lm_basic_reduce
edps -w metis.metis_lm_img_wkf -i $SOF_DATA -t metis_lm_img_basic_reduce

```

Expand Down
2 changes: 1 addition & 1 deletion metisp/pymetis/src/pymetis/recipes/img/metis_lm_img_basic_reduce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ class MetisLmImgBasicReduce(MetisRecipe):
- and finally define the implementation class, which we have just written
"""
# Fill in recipe information
_name = "metis_lm_basic_reduce"
_name = "metis_lm_img_basic_reduce"
_version = "0.1"
_author = "Chi-Hung Yan"
_email = "[email protected]"
Expand Down
2 changes: 1 addition & 1 deletion ...metis/tests/test_metis_lm_basic_reduce.py → ...s/tests/test_metis_lm_img_basic_reduce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

@pytest.fixture
def name():
return 'metis_lm_basic_reduce'
return 'metis_lm_img_basic_reduce'


@pytest.fixture
Expand Down
4 changes: 2 additions & 2 deletions metisp/workflows/metis/metis_lm_img_wkf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@
.with_recipe("metis_lm_img_flat")
.build())

basic_reduction = (task('metis_lm_basic_reduce')
.with_recipe('metis_lm_basic_reduce')
basic_reduction = (task('metis_lm_img_basic_reduce')
.with_recipe('metis_lm_img_basic_reduce')
.with_main_input(lm_raw_science)
.with_associated_input(lingain_task)
.with_associated_input(dark_task)
Expand Down