Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] .net core #16

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

[WIP] .net core #16

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 18, 2017

  • Add support for .net45 (need to review the travis build)
  • Added documentation
  • removed "dynamic" API, in order to simplify the usage of the wrapper

<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netcoreapp1.1</TargetFramework>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to add .net45 support you need to write: <TargetFramework>netcoreapp1.1;net45</TargetFramework>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could actually use https://docs.microsoft.com/en-us/dotnet/standard/net-standard netstandard1.1 to support .net 45 and core ...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the tests I'm not sure that there is a need for multiple target frameworks

@donniefitz2
Copy link

Is this going to be merged? I really need .Net Core support to use Assembly.

@wallymathieu
Copy link

First they need to review the changes. It's fully possible that this quite large pull request will be rejected. I've done a lot of changes that they might not agree with. For instance I've tried to refactor it a bit to match more the style of .net core libraries. I've removed the "Dynamic" parts (in order to be a bit more .net-y and cut down on the amount of code that needs to be tested).

What you can do is to create a public nuget feed and do dotnet pack and then nuget push to that feed.
We have our own feed for that purpose:
https://www.myget.org/feed/carable-public/package/nuget/PromisePay.API.NET
Since we need .net core support as well. It is however a feed for the open source work for @carable. I.e. not any official prerelease feed from AssemblyPayments.

@wallymathieu
Copy link

Instead of targeting .net 45 targeting netstandard: https://docs.microsoft.com/en-us/dotnet/standard/net-standard

@wallymathieu
Copy link

We have made a carable fork of it: https://github.com/carable/carable.assemblypayments
It is uploaded to nuget. It has a different type of design than promisepay-net package. You can probably close this pull request (since there hasn't been any activity on it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants