Invert type hierarchy of request.line #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't limit method length to 64, it's not part of the spec and it accomplishes nothing - use a 400 response code instead of 501 when the method is invalid
Changaco
force-pushed
the
request-invert
branch
from
6bfa5d4 to
b1e743f
Compare
|
I have two other branches ready on top of this. |
|
(I'm going offline for the rest of the day.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #222.
Note that it also modifies the handling of HTTP methods: it removes the length limit of 64 and changes the response code from 501 to 400 when the method is invalid.