-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create review subtasks for requested reviewers #110
Draft
magnus-asana
wants to merge
2
commits into
master
Choose a base branch
from
feat/create_review_subtasks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
from .subtask import Subtask |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
from typing import Optional, Dict, Any | ||
import copy | ||
|
||
|
||
class Subtask(object): | ||
def __init__(self, raw_subtask: Dict[str, Any]): | ||
self._raw = copy.deepcopy(raw_subtask) | ||
|
||
def id(self) -> str: | ||
return self._raw["gid"] | ||
|
||
def completed(self) -> bool: | ||
return self._raw["completed"] | ||
|
||
def assignee_id(self) -> Optional[str]: | ||
if self._raw["assignee"] is None: | ||
return None | ||
|
||
return self._raw["assignee"]["gid"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -210,6 +210,33 @@ def get_asana_domain_user_id_from_github_handle(github_handle: str) -> Optional[ | |
) | ||
|
||
|
||
def get_asana_id_from_two_github_node_ids(gh_node_id_a: str, gh_node_id_b: str) -> Optional[str]: | ||
""" | ||
Using the singleton instance of DynamoDbClient, creating it if necessary: | ||
|
||
Retrieves the Asana object-id associated with the specified GitHub node-ids, | ||
or None, if no such association exists. Object-table associations are created | ||
by SGTM via the insert_github_node_to_asana_id_mapping method, below. | ||
""" | ||
return DynamoDbClient.singleton().get_asana_id_from_github_node_id( | ||
_get_dynamodb_key_from_two_github_nodes(gh_node_id_a, gh_node_id_b) | ||
) | ||
|
||
|
||
def insert_two_github_node_to_asana_id_mapping(gh_node_id_a: str, gh_node_id_b: str, asana_id: str): | ||
""" | ||
Using the singleton instance of DynamoDbClient, creating it if necessary: | ||
|
||
Creates an association between two GitHub node-ids and an Asana object-id. The dynamoDb | ||
key is formed by concatenating the two GitHub node ids using a "-" separator. | ||
""" | ||
dynamo_db_key = _get_dynamodb_key_from_two_github_nodes(gh_node_id_a, gh_node_id_b) | ||
print(f"Inserting key {dynamo_db_key} to DynamoDb.") | ||
return DynamoDbClient.singleton().insert_github_node_to_asana_id_mapping( | ||
_get_dynamodb_key_from_two_github_nodes(gh_node_id_a, gh_node_id_b), asana_id | ||
) | ||
|
||
|
||
def get_all_user_items() -> List[dict]: | ||
return DynamoDbClient.singleton().get_all_user_items() | ||
|
||
|
@@ -236,3 +263,6 @@ def bulk_insert_github_handle_to_asana_user_id_mapping( | |
DynamoDbClient.singleton().bulk_insert_github_handle_to_asana_user_id_mapping( | ||
gh_and_asana_ids | ||
) | ||
|
||
def _get_dynamodb_key_from_two_github_nodes(gh_node_id_a: str, gh_node_id_b: str) -> str: | ||
return f"{gh_node_id_a}-{gh_node_id_b}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps this function should sort the two node ids, so we don't have to remember which order to pass them in and reduce bugs around unexpected orders |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.