Merge pull request #20 from AsBuiltReport/dev

v0.1.8.2
AsBuiltReport · Nov 15, 2024 · 6fce6ee · 6fce6ee
2 parents 2349097 + 8d4779e
commit 6fce6ee
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 9 deletions.
diff --git a/AsBuiltReport.Microsoft.Azure.psd1 b/AsBuiltReport.Microsoft.Azure.psd1
@@ -12,7 +12,7 @@
 RootModule = 'AsBuiltReport.Microsoft.Azure.psm1'
 
 # Version number of this module.
-ModuleVersion = '0.1.8.1'
+ModuleVersion = '0.1.8.2'
 
 # Supported PSEditions
 # CompatiblePSEditions = @()

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,14 @@
 # :arrows_clockwise: Microsoft Azure As Built Report Changelog
 
+## [[0.1.8.2](https://github.com/AsBuiltReport/AsBuiltReport.Microsoft.Azure/releases/tag/v0.1.8.2)] - 2024-11-15
+
+### Fixed
+* Fix issue where a report would not be generated if `Subscription` InfoLevel was set to 0
+
+### Changed
+* Change Storage Account `Minimum TLS Version` healthcheck to highlight Critical
+
+
 ## [[0.1.8.1](https://github.com/AsBuiltReport/AsBuiltReport.Microsoft.Azure/releases/tag/v0.1.8.1)] - 2024-11-13
 
 ### Added

diff --git a/README.md b/README.md
@@ -88,7 +88,8 @@ The least privileged roles required to generate a Microsoft Azure As Built Repor
 <!-- ********** Add installation for any additional PowerShell module(s) ********** -->
 Open a PowerShell terminal window and install each of the required modules.
 
-:warning: Microsoft Az 12.0.0 or higher is required. Please ensure older Az modules have been uninstalled.
+> [!NOTE]
+> Microsoft Az 12.0.0 or higher is required. Please ensure older Az modules have been uninstalled.
 
 ```powershell
 # Install
@@ -119,7 +120,7 @@ _Note: You are not limited to installing the module to those example paths, you
 The Microsoft Azure As Built Report utilises a JSON file to allow configuration of report information, options, detail and healthchecks.
 
 > [!IMPORTANT]
-> Please rememeber to generate a new report JSON configuration file after each module update to ensure the report functions correctly.
+> Please remember to generate a new report JSON configuration file after each module update to ensure the report functions correctly.
 
 A Microsoft Azure report configuration file can be generated by executing the following command;
 ```powershell
@@ -240,7 +241,7 @@ The **StorageAccount** schema is used to configure health checks for Azure Stora
 | SecureTransfer            | true / false | true    | Highlights storage accounts which do not have secure transfer enabled           | ![Warning](https://via.placeholder.com/15/FFF4C7/FFF4C7.png) Secure transfer is disabled                                       |
 | BlobAnonymousAccess     | true / false | true    | Highlights storage accounts which have Blob anonymous read access enabled            | ![Warning](https://via.placeholder.com/15/FFF4C7/FFF4C7.png) Anonymous read access is enabled                                       |
 | PublicNetworkAccess     | true / false | true    | Highlights storage accounts which have public network access enabled            | ![Warning](https://via.placeholder.com/15/FFF4C7/FFF4C7.png) Public network access is enabled                                     |
-| MinimumTlsVersion       | true / false | true    | Highlights storage accounts which have TLS 1.0 or TLS 1.1 configured            | ![Warning](https://via.placeholder.com/15/FFF4C7/FFF4C7.png) TLS version 1.0 or 1.1 configured                                      |
+| MinimumTlsVersion       | true / false | true    | Highlights storage accounts which have TLS 1.0 or TLS 1.1 configured            | ![Citical](https://via.placeholder.com/15/FEDDD7/FEDDD7.png) TLS version 1.0 or 1.1 configured                                      |
 
 #### VirtualMachine
 The **VirtualMachine** schema is used to configure health checks for Azure Virtual Machines.

diff --git a/Src/Private/Get-AbrAzStorageAccount.ps1 b/Src/Private/Get-AbrAzStorageAccount.ps1
@@ -5,7 +5,7 @@ function Get-AbrAzStorageAccount {
     .DESCRIPTION
 
     .NOTES
-        Version:        0.1.6
+        Version:        0.1.7
         Author:         Jonathan Colon / Tim Carman
         Twitter:        @jcolonfzenpr / @tpcarman
         Github:         rebelinux / tpcarman
@@ -78,7 +78,7 @@ function Get-AbrAzStorageAccount {
                                 } else {
                                     'Disabled'
                                 }
-                                'Minimum TLS Version' = ($AzStorageAccount.MinimumTlsVersion).Replace('_','.')
+                                'Minimum TLS Version' = $AzStorageAccount.MinimumTlsVersion -Replace "TLS(\d)_(\d)", 'TLS $1.$2'
                                 'Infrastructure Encryption' = if ($AzStorageAccount.RequireInfrastructureEncryption) {
                                     'Enabled'
                                 } else {
@@ -115,7 +115,7 @@ function Get-AbrAzStorageAccount {
                         }
 
                         if ($Healthcheck.StorageAccount.MinimumTlsVersion) {
-                            $AzStorageAccountInfo | Where-Object { $_.'Minimum TLS Version' -ne 'TLS1.2' } | Set-Style -Style Warning -Property 'Minimum TLS Version'
+                            $AzStorageAccountInfo | Where-Object { $_.'Minimum TLS Version' -ne 'TLS 1.2' } | Set-Style -Style Critical -Property 'Minimum TLS Version'
                         }
 
                         if ($InfoLevel.StorageAccount -ge 2) {

diff --git a/Src/Private/Get-AbrAzSubscription.ps1 b/Src/Private/Get-AbrAzSubscription.ps1
@@ -5,7 +5,7 @@ function Get-AbrAzSubscription {
     .DESCRIPTION
 
     .NOTES
-        Version:        0.1.2
+        Version:        0.1.3
         Author:         Tim Carman
         Twitter:        @tpcarman
         Github:         tpcarman
@@ -53,7 +53,6 @@ function Get-AbrAzSubscription {
                 $AzSubscriptionInfo | Table @TableParams
             } else {
                 Write-PScriboMessage -IsWarning 'No subscriptions found.'
-                Break
             }
         } Catch {
             Write-PScriboMessage -IsWarning $($_.Exception.Message)